New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v452 Hard Fork #413

Merged
merged 29 commits into from Feb 10, 2019

Conversation

Projects
None yet
4 participants
@craigmacgregor
Copy link
Member

craigmacgregor commented Feb 3, 2019

Updated versioning to 4.5.2

Enforce version bit 21 for all blocks after 2882875.

The RPC test has also been made more generic so you just pass in the version bit and activation height rather than needing a function for each version bit.

Need to write a test to cover the functionality which checks if height has been reached when rejecting blocks with invalid CFund payment requests.

craigmacgregor added some commits Feb 3, 2019

@craigmacgregor craigmacgregor self-assigned this Feb 4, 2019

marcus290 and others added some commits Feb 4, 2019

Merge pull request #11 from marcus290/add-payout-test
Adds test for double preq payout before and after fork
@marcus290
Copy link
Contributor

marcus290 left a comment

Currently one test (wallet.py) failed randomly in Travis for one build but not the other. I don't think it's related to this PR and I have recorded it in a separate issue #416

Rerunning Travis would likely result in a pass

@marcus290 marcus290 requested a review from matt-auckland Feb 7, 2019

@craigmacgregor craigmacgregor changed the title [WIP] v452 v452 Feb 10, 2019

@craigmacgregor craigmacgregor changed the title v452 v452 Hard Fork Feb 10, 2019

@craigmacgregor craigmacgregor merged commit 7ef765b into NAVCoin:master Feb 10, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@craigmacgregor craigmacgregor deleted the craigmacgregor:v452 branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment