Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Wallet Community Fund UI Improvement #428

Merged
merged 226 commits into from Mar 18, 2019

Conversation

Projects
None yet
5 participants
@hdnsimpson
Copy link
Contributor

hdnsimpson commented Feb 27, 2019

image

  • Added a Community Fund tab to the core wallet
  • Ability to view and filter proposals and payment request
  • Proposals and payment requests can be voted on and created
  • Removed the old Community Fund UI

dy5es41 and others added some commits Feb 5, 2019

@craigmacgregor craigmacgregor requested review from aguycalled , marcus290 , craigmacgregor and matt-auckland and removed request for aguycalled and marcus290 Mar 6, 2019

@marcus290
Copy link
Contributor

marcus290 left a comment

I've manually tested the UI on regtest for viewing proposals/payment requests in different states, changes in vote numbers and states. I've also checked the display of current proposals/payment requests on mainnet. Looks good to me!

For createproposal / createpaymentrequest UI, I can also confirm there are the same checks as the rpc commands.

I gave some feedback but these have already been addressed in some of the commits after 2ecfdcf.

@red010b37
Copy link
Member

red010b37 left a comment

Im only part way through - will finish the rest later, all super minor and more code hygiene than anything major

Show resolved Hide resolved src/qt/communityfunddisplay.cpp Outdated
Show resolved Hide resolved src/qt/communityfunddisplaydetailed.cpp Outdated
Show resolved Hide resolved src/qt/communityfunddisplaydetailed.cpp Outdated
Show resolved Hide resolved src/qt/communityfunddisplaypaymentrequest.cpp Outdated
Show resolved Hide resolved src/qt/communityfunddisplaypaymentrequestdetailed.cpp Outdated
Show resolved Hide resolved src/qt/communityfundpage.cpp Outdated
Show resolved Hide resolved src/qt/communityfundpage.cpp Outdated
Show resolved Hide resolved src/qt/sendcommunityfunddialog.cpp Outdated
Show resolved Hide resolved src/qt/sendcommunityfunddialog.cpp Outdated
Show resolved Hide resolved src/qt/communityfunddisplay.cpp Outdated
@aguycalled

This comment has been minimized.

Copy link
Member

aguycalled commented Mar 7, 2019

everything looks quite good from what i've tested in devnet. i only miss a filter for seeing proposals/prequests in pending state for which I haven't voted yet. this should be the view I see when I click the open community fund button from the new proposals alert dialog.

@aguycalled aguycalled merged commit cbffaee into NAVCoin:master Mar 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.