Feature/renaming #378

silverdaz · 2018-12-07T17:18:21Z

Describe the pull request:

Pull request long description:

Renaming some components

Changes made:

I renamed some components.
And I added flake8 to tox dependencies (I think it was missing)
I added a dev-mode to use dummy passwords

Related issues:

Moves #380 forward

Additional information:

Release note:

Documentation change:

Mentions:

@blankdots, @viklund, @jbygdell

jbygdell

50313cc
The path renaming docker -> deploy should go into a separate commit.

deploy/bootstrap/lega.sh

deploy/test/Makefile

deploy/tests/src/test/resources/config.properties

deploy/bootstrap/lega.sh

requirements.txt

README.md

.travis.yml

deploy/bootstrap/lega.sh

jbygdell · 2018-12-12T06:56:21Z

deploy/bootstrap/lega.sh

    volumes:
       - ./lega/conf.ini:/etc/ega/conf.ini:ro
    restart: on-failure:3
    networks:
      - lega
-    entrypoint: ["gosu", "lega", "ega-id-mapper"]
+    entrypoint: ["gosu", "lega", "ega-finalize"]

  # Ingestion Workers


Since you are renaming both id-mapper to finalize and s3 to vault.
You should say that in the body of the commit message, if there would have been two separate commits then the same information would have fit in then commit title.

jbygdell · 2018-12-12T06:57:42Z

.travis.yml

-        - docker-compose ps
-      script:
-        - sleep 5
-        - pip install -r https://raw.githubusercontent.com/NBISweden/LocalEGA-cryptor/master/requirements.txt


Remove this commit

jbygdell · 2018-12-12T06:58:08Z

.travis.yml

-    #     - sudo chown -R travis private
-    #     - docker network create cega
-    #     - docker-compose up -d #--scale ingest=3 --scale verify=5
-    #     - docker-compose ps


Remove this commit

dtitov · 2018-12-12T08:33:48Z

After force-push my comments disappear, so I'll comment here once again.

Why rename docker to deploy? Yes it’s deployment, but it’s still Docker deployment. Both terms are correct, so why would we do anything about it? Just some redundant modifications, as for me. It was never explained neither here, nor in Slack, although I asked.
With id-mapper -> finalize it’s up to you, of course, because it was your idea to add this component to LocalEGA. Maybe it really needs some more generic name. Maybe not. I would personally not touch it as well, but, again, I care less about this renaming.
The most important here: why rename s3 to vault? Some time ago we had a separate component called Vault, it was functional module (i.e. microservice). And now it would confuse at least me, that we have Vault again, but now it’s not a microservice, but just a storage server. I would rather keep it as S3. Also Jocke mentioned that Vault can be confused with Hashicorp’s Vault for newcomers and I agree with that. And, at last, it's called S3 in Data Out, so for the sake of consistency, we need to follow common naming schemas.

silverdaz requested a review from blankdots December 7, 2018 17:18

silverdaz self-assigned this Dec 7, 2018

silverdaz added this to the Sprint 41 milestone Dec 7, 2018

silverdaz force-pushed the feature/renaming branch 2 times, most recently from 594c451 to f721a82 Compare December 7, 2018 17:30