From 9e2fb006f4d16757ed2b862e38a3358aeabde7a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20=C3=96stberg?= Date: Wed, 28 Aug 2019 12:31:13 +0200 Subject: [PATCH 1/3] Remove unintended error log. --- backend/modules/browser/browser_handlers.py | 1 - 1 file changed, 1 deletion(-) diff --git a/backend/modules/browser/browser_handlers.py b/backend/modules/browser/browser_handlers.py index 3a726d068..ceb40f940 100644 --- a/backend/modules/browser/browser_handlers.py +++ b/backend/modules/browser/browser_handlers.py @@ -356,7 +356,6 @@ def get(self, dataset: str, variant: str, ds_version: str = None): if dset.short_name != dataset] # if the only available version is not released yet dsvs = list(filter(lambda dsv: dsv, dsvs)) - logging.error(dsvs) dsvs = [dsv for dsv in dsvs if dsv.reference_set == curr_dsv.reference_set] dsv_groups = [(curr_dsv, variant)] for dsv in dsvs: From 0ceb5c1ae86b40f2c1561ee218ff37cac499eb45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20=C3=96stberg?= Date: Wed, 28 Aug 2019 12:34:25 +0200 Subject: [PATCH 2/3] Decrease logging severity to info for missing variants. --- backend/modules/browser/browser_handlers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/modules/browser/browser_handlers.py b/backend/modules/browser/browser_handlers.py index ceb40f940..0ca63b936 100644 --- a/backend/modules/browser/browser_handlers.py +++ b/backend/modules/browser/browser_handlers.py @@ -303,7 +303,7 @@ def get(self, dataset: str, variant: str, ds_version: str = None): variant = lookups.get_variant(dataset, split_var[1], split_var[0], split_var[2], split_var[3], ds_version) except error.NotFoundError as err: - logging.error('Variant not found ({})'.format(orig_variant)) + logging.info('Variant not found ({})'.format(orig_variant)) self.send_error(status_code=404, reason=str(err)) return From f437a0f233cabad460b65201a33724620d40a964 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20=C3=96stberg?= Date: Wed, 28 Aug 2019 12:36:48 +0200 Subject: [PATCH 3/3] Change logging severities. --- backend/modules/browser/browser_handlers.py | 2 +- backend/modules/browser/lookups.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/modules/browser/browser_handlers.py b/backend/modules/browser/browser_handlers.py index 0ca63b936..2ec7380a9 100644 --- a/backend/modules/browser/browser_handlers.py +++ b/backend/modules/browser/browser_handlers.py @@ -201,7 +201,7 @@ def get(self, dataset: str, region: str, ds_version: str = None): chrom, start, stop = utils.parse_region(region) except error.ParsingError as err: self.send_error(status_code=400, reason=str(err)) - logging.warning('GetRegion: unable to parse region ({})'.format(region)) + logging.error('GetRegion: unable to parse region ({})'.format(region)) return ret = {'region': {'chrom': chrom, diff --git a/backend/modules/browser/lookups.py b/backend/modules/browser/lookups.py index d538fab57..c59241707 100644 --- a/backend/modules/browser/lookups.py +++ b/backend/modules/browser/lookups.py @@ -444,7 +444,7 @@ def get_transcripts_in_gene(dataset: str, gene_id: str, ds_version: str = None) try: ref_set = db.get_dataset_version(dataset, ds_version).reference_set except AttributeError as err: - logging.warning(f'get_transcripts_in_gene({dataset}, {gene_id}): unable to get ref dbid') + logging.info(f'get_transcripts_in_gene({dataset}, {gene_id}): unable to get ref dbid') raise error.NotFoundError(f'Reference set not found for dataset {dataset}.') from err try: