Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hsl and hsla color format support #7

Merged
merged 1 commit into from Aug 19, 2019
Merged

Add hsl and hsla color format support #7

merged 1 commit into from Aug 19, 2019

Conversation

Smankusors
Copy link
Contributor

@Smankusors Smankusors commented Aug 18, 2019

Well this library is using HSV color model, but doesn't support HSL/HSLA input format... So, why not add this feature into this library?

@NC22 NC22 merged commit ef1ee87 into NC22:master Aug 19, 2019
@NC22
Copy link
Owner

@NC22 NC22 commented Aug 19, 2019

@Smankusors Thanks. I merge and added few little changes to prevent compatibility issues with private methods. I'll update minified version bit later

@Smankusors
Copy link
Contributor Author

@Smankusors Smankusors commented Aug 19, 2019

@NC22 ehm wait, why you updated the version from 1.19 to 1.2? The number feels like downgraded...

@NC22
Copy link
Owner

@NC22 NC22 commented Aug 19, 2019

@Smankusors eh... its my habbit, I count minor changes as third digit or if reach 9 go to next second dig - so versions goes 1.2, 1.21, 1.22, 1.3 etc. I can add zero at the end if this confuse

@Smankusors
Copy link
Contributor Author

@Smankusors Smankusors commented Aug 19, 2019

@NC22 well I suggest that you write 1.21 as 1.2.1. But hey, that's up to you. But I find this is weird versioning 😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants