New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update radar obs_converter README #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
One broken link in the list of converters.
obs_converters/README.rst link needs changing to the newfile name:
- `Radar <radar/radar.html>`__
+ `Radar <radar/README.html>`__
Plus, Jeff's comment about adding a link to Alain's pdf.
Two quick questions: Fix all the obs_converter links?While I'm editing
For example, instead of putting in the HTML link (which is typically used to reference external pages):
It would be the Sphinx
The reason that my test build of Sphinx didn't catch the broken link is that it doesn't check for broken html links. It only checks for broken Okay to omit Alain's PDF in the obs_converter README?I did some digging. Alain's PDF actually describes the forward operator not the observation converter. We have some documentation of it already:
|
yup both of those make sense |
I modified the obs_converter lists in both:
While I was at it, I also reformatted the CHAMP
|
Description:
Update the radar obs_converter README to consolidate Glen's guidance from this issue #37 into the documentation.
Fixes issue
Fixes Github issue #228 .
Types of changes
Documentation changes needed?
Tests
I rebuilt the documentation on my local machine using Sphinx to ensure that this documentation update builds correctly and does not cause any unintended issues.
Checklist for merging
Testing Datasets