Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error checking for 0 fields requested in Grid-Stat. #1195

Closed
JohnHalleyGotway opened this issue Sep 13, 2019 · 1 comment
Closed
Assignees
Labels
requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working

Comments

@JohnHalleyGotway
Copy link
Collaborator

Jeff Hamilton at NOAA/GSD received a confusing error message from Grid-Stat:
ERROR : GridStatVxOpt::process_config() -> At least one output STAT or NetCDF type must be requested in "output_flag" or "nc_pairs_flag".

The underlying problem is that the list of fields to be verified was length 0. The error should have read:
ERROR : GridStatConfInfo::process_config() -> The number of verification tasks in "obs.field" (0) must be non-zero and match the number in "fcst.field" (0).

Correct this oversight in validating the configuration in both Grid-Stat and Ensemble-Stat.

@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: application code requestor: NOAA/GSL NOAA Global Systems Laboratory labels Sep 13, 2019
@JohnHalleyGotway JohnHalleyGotway added this to the MET 8.1.2 (bugfix) milestone Sep 13, 2019
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 13, 2019
JohnHalleyGotway added a commit that referenced this issue Sep 13, 2019
@JohnHalleyGotway JohnHalleyGotway changed the title Correct error checking for 0 fields requested in Grid-Stat and Ensemble-Stat. Correct error checking for 0 fields requested in Grid-Stat. Sep 13, 2019
@JohnHalleyGotway
Copy link
Collaborator Author

Fix this in master_v8.1 and develop. I originally thought it should be fixed in grid-stat and ensemble-stat. However, it's ok to have 0 verification fields in ensemble-stat. But in grid-stat, the number of vx tasks must be non-zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working
Projects
None yet
Development

No branches or pull requests

1 participant