Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vx_data2d_nccf library to support all documented variants of time units. #1245

Closed
JohnHalleyGotway opened this issue Jan 30, 2020 · 0 comments
Closed

Update vx_data2d_nccf library to support all documented variants of time units. #1245

JohnHalleyGotway opened this issue Jan 30, 2020 · 0 comments
Assignees
@JohnHalleyGotway
Labels
MET: Library Code requestor: Community General Community type: bug Fix something that is not working
Milestone
MET 9.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

This issue arose via met-help:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=93980

Update met/src/libcode/vx_data2d_nccf/nccf_file.cc to support all the time unit variations indicated here:
http://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/cf-conventions.html#time-coordinate

The acceptable units for time are listed in the udunits.dat file. The most commonly used of these strings (and their abbreviations) includes day (d), hour (hr, h), minute (min) and second (sec, s). Plural forms are also acceptable.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: library code requestor: Community General Community labels Jan 30, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.0 milestone Jan 30, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jan 30, 2020
JohnHalleyGotway added a commit that referenced this issue Jan 30, 2020
@JohnHalleyGotway
Fix for #1245 handling more time unit variants. Should also consider …
3c6affa 
…identifying lat/lon by standard_name instead of units.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

Labels
MET: Library Code requestor: Community General Community type: bug Fix something that is not working
Projects
None yet
Milestone
MET 9.0
Development

No branches or pull requests
1 participant
@JohnHalleyGotway