-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template #468
Merged
Merged
Update PR template #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anissa111
reviewed
Sep 13, 2023
.github/PULL_REQUEST_TEMPLATE.md
Outdated
@@ -8,12 +8,12 @@ apply to this PR, comment it out or delete it. --> | |||
**General** | |||
- [ ] Make an issue if one doesn't already exist | |||
- [ ] Link the issue this PR resolves by adding `closes #XXX` to the PR description where XXX is the number of the issue. | |||
- [ ] Add a brief summary of changes to `docs/release-notes.rst` | |||
- [ ] If needed, squash and merge PR commits into a single commit to clean up commit history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small point, but could we put the squash and merge item last in the general section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
anissa111
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #455
Changes to the PR template (
.github/PULL_REQUEST_TEMPLATE.md
):PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
@NCAR/geocat
for reviewsprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.