Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

massFlux and parentSI seem incompatible #284

Closed
maier-m opened this issue Feb 14, 2018 · 4 comments
Closed

massFlux and parentSI seem incompatible #284

maier-m opened this issue Feb 14, 2018 · 4 comments
Assignees
Milestone

Comments

@maier-m
Copy link
Contributor

@maier-m maier-m commented Feb 14, 2018

massFlux has a parentSI of kilogramsPerSecond
A more appropriate massFlux SI would be kilogramsPerSquareMeterPerSecond
kilogramsPerSecond would be more appropriately massRate

@mobb

This comment has been minimized.

Copy link
Contributor

@mobb mobb commented May 2, 2018

agreed (flux has area in the denominator).
also applies to amountOfSubstanceWeightFlux, which might be a mass-specific rate (?)

other instances of the term "flux" to note:

  1. massflux unitType is named arealMassDensityRate, which is fine as is.

  2. magneticFlux and magneticFluxDensity include area - sometimes in the numerator, sometimes denominator. Perhaps this is because of unit reductions? Knowing nothing about magnetism, I am not qualified to edit these.

@mobb

This comment has been minimized.

Copy link
Contributor

@mobb mobb commented Jun 29, 2018

Also note, this one is actually is a mass "flux", but is called a rate.

simplest solution is to rename the unitTypes, and confirm the children match:

massFlux
<unitType id="arealMassDensityRate" name="arealMassDensityRate"> <!--kilogramsPerMeterSquaredPerSecond--> <dimension name="mass"/> <dimension name="length" power="-2"/> <dimension name="time" power="-1"/> </unitType>

amountOfSubstanceWeightRate
<unitType id="amountOfSubstanceWeightFlux" name="amountOfSubstanceWeightFlux"> <!--molesPerKilogramPerSecond--> <dimension name="amount"/> <dimension name="mass" power="-1"/> <dimension name="time" power="-1"/> </unitType>

massRate:
<unitType id="massFlux" name="massFlux"> <!--kilogramsPerSecond--> <dimension name="mass"/> <dimension name="time" power="-1"/> </unitType

@mobb

This comment has been minimized.

Copy link
Contributor

@mobb mobb commented Jun 29, 2018

related to #285

@mobb

This comment has been minimized.

Copy link
Contributor

@mobb mobb commented Jul 3, 2018

  1. massFlux is now massRate
  2. arealMassDensityRate is now massFlux
  3. amountOfSubstanceWeightFlux is now amountOfSubstanceWeightRate
@mobb mobb closed this Jul 3, 2018
@gothub gothub removed the in progress label Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.