Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The citation-* test files in the 2.2.0 testing suite still point to the 2.1.1 schema? #304

Closed
cboettig opened this issue May 2, 2018 · 4 comments
Assignees
Milestone

Comments

@cboettig
Copy link
Member

@cboettig cboettig commented May 2, 2018

I'm not sure if this is really a problem or not, but I noticed that https://github.com/NCEAS/eml/tree/BRANCH_EML_2_2/src/test/resources, the citation-* files are still all pointing to the schema 2.1.1 schema. Is that intentional?

@mbjones mbjones self-assigned this May 2, 2018
@mbjones mbjones added this to the EML2.2.0 milestone May 2, 2018
@mbjones

This comment has been minimized.

Copy link
Contributor

@mbjones mbjones commented May 2, 2018

Just hadn't gotten there yet. I changed a few of the docs in the src/test/resources over to using the 2.2 namespace, but not all of them yet. I'll add this ticket to the 2.2 milestone and flag it to be done.

@cboettig

This comment has been minimized.

Copy link
Member Author

@cboettig cboettig commented May 2, 2018

okay, cool. Does the test suite include the bibtex-based citation styles too? (Just started testing emld / eml2 against 2.2.0 schema in https://github.com/cboettig/emld/tree/eml-2.2 and realized these were all still at 2.1.1)

@mbjones

This comment has been minimized.

Copy link
Contributor

@mbjones mbjones commented May 2, 2018

I've put some of the bibtex stuff into the eml-data-paper.xml, so it gets validated there in the tests. But it should also be added to the citation/literature test files when they get updated.

@mbjones mbjones added next and removed next labels May 3, 2018
mbjones added a commit that referenced this issue Jun 29, 2018
Work towards #304.
@mbjones

This comment has been minimized.

Copy link
Contributor

@mbjones mbjones commented Jun 29, 2018

Updated namespace of all citation-test* docs in sha c494365 -- all seems to be working for now.

@mbjones mbjones closed this Jun 29, 2018
@mbjones mbjones removed the in progress label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.