Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in spatialReference.xsd referencing #326

Closed
amoeba opened this issue Nov 29, 2018 · 3 comments
Closed

Typo in spatialReference.xsd referencing #326

amoeba opened this issue Nov 29, 2018 · 3 comments
Assignees
Milestone

Comments

@amoeba
Copy link
Contributor

@amoeba amoeba commented Nov 29, 2018

@jeanetteclark noticed this today on Slack: There's a typo (wrong extension) in eml/spatialReference.xsd in a reference to the eml-spatialReferenceDictionary.xml file:

<doc:summary>The name of a predefined coordinate system</doc:summary>
<doc:description>The name of a coordinate system for which a definition has been
provided in the eml-spatialReferenceDictionary.xsl file.</doc:description>

eml-spatialReferenceDictionary.xsl should be eml-spatialReferenceDictionary.xml

I'll hold off on changing this since the docs are in flux for the EML 2.2 release.

@amoeba

This comment has been minimized.

Copy link
Contributor Author

@amoeba amoeba commented Nov 29, 2018

@jeanetteclark made a good suggestion too: It'd be nice if references like this are hyperlinks in the docs so the user can find this file without downloading a full release of EML or checking the repo.

mbjones added a commit that referenced this issue Dec 1, 2018
Fixes #326.
@mbjones

This comment has been minimized.

Copy link
Contributor

@mbjones mbjones commented Dec 1, 2018

OK, I fixed this in the 2.2 branch schema file, and it will now be included in the release with the right name.

I don't know how to provide a link, as the schemas are used to generate docs in many contexts, some online, some not, and we have no knowledge of the html files that might be generated from these source files. Suggestions welcome, but for now I am not planning on adding a link.

@mbjones mbjones added the needs-review label Dec 1, 2018
@mbjones mbjones added this to the EML2.2.0 milestone Dec 1, 2018
@mbjones mbjones self-assigned this Dec 1, 2018
@amoeba

This comment has been minimized.

Copy link
Contributor Author

@amoeba amoeba commented Dec 3, 2018

Thanks, @mbjones, that's probably good enough. I'm okay with this Issue getting closed now. I don't have any suggestions for linkifying the reference in the in-schema docs.

@mbjones mbjones closed this Jan 31, 2019
@mbjones mbjones removed the needs-review label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.