Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we prevent MetacatServlet startup if the initSecondHalf method fails? #1721

Closed
taojing2002 opened this issue Nov 1, 2023 · 2 comments
Assignees
Milestone

Comments

@taojing2002
Copy link
Contributor

In the MetacatServlet class, we have a method named initSecondHalf, which registers all services. If it fails, Metacat will prevent any old Metacat API calls. But we removed all old Metacat API calls, this mechanism doesn't work anymore. We need to another mechanism to prevent MetacatServlet startup if that method fails.

@taojing2002 taojing2002 added this to the 3.0.0 milestone Nov 1, 2023
@mbjones
Copy link
Member

mbjones commented Nov 1, 2023

I'm pretty sure that @artntek added some new checks on Metacat startup to ensure things are properly working -- and to exit metacat if they fail. Maybe we can reuse that same mechanism? The initSecondHalf method has always felt a bit mysterious to me.

@artntek
Copy link
Contributor

artntek commented Nov 1, 2023

@taojing2002 taojing2002 self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants