From 4f7fb807cbeb8ef804f94ddafc4e2a0fbc242c47 Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Wed, 9 Aug 2023 12:45:11 +0200 Subject: [PATCH 1/2] Fixed a typo. Thanks @xtruthx for finding it. fixes #217 --- docs/role-elasticsearch.md | 2 +- roles/elasticsearch/templates/elasticsearch.yml.j2 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/role-elasticsearch.md b/docs/role-elasticsearch.md index 566094bc..e9e5add3 100644 --- a/docs/role-elasticsearch.md +++ b/docs/role-elasticsearch.md @@ -31,7 +31,7 @@ Role Variables * *elasticsearch_fs_repo*: List of paths that should be registered as repository for snapshots (only filesystem supported so far). (default: none) Remember, that every node needs access to the same share under the same path. * *elasticsearch_bootstrap_pw*: Bootstrap password for Elasticsearch (Default: `PleaseChangeMe`) * *elasticsearch_disable_systemcallfilterchecks*: Disable system call filter checks. This has a security impact but is necessary on some systems. Please refer to the [docs](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/_system_call_filter_check.html) for details. (default: `false`) -* *ealsticsearch_http_publish_host*: (String) The network address for HTTP clients to contact the node using sniffing. Accepts an IP address, a hostname, or a special value. (default: `not set`) +* *elasticsearch_http_publish_host*: (String) The network address for HTTP clients to contact the node using sniffing. Accepts an IP address, a hostname, or a special value. (default: `not set`) * *ealsticsearch_http_publish_port*: (integer) The port of the HTTP publish address. Configure this setting only if you need the publish port to be different from http.port. (default: `not set`) * *elasticsearch_pamlimits*: Set pam_limits neccessary for Elasticsearch. (Default: `true`) * *elasticsearch_check_calculation*: End play in checks (Default: `false`) diff --git a/roles/elasticsearch/templates/elasticsearch.yml.j2 b/roles/elasticsearch/templates/elasticsearch.yml.j2 index 04aed127..de21f7fe 100644 --- a/roles/elasticsearch/templates/elasticsearch.yml.j2 +++ b/roles/elasticsearch/templates/elasticsearch.yml.j2 @@ -3,8 +3,8 @@ path.data: {{ elasticsearch_datapath }} path.logs: {{ elasticsearch_logpath }} cluster.name: "{{ elasticsearch_clustername }}" network.host: ["_local_","_site_"] -{% if ealsticsearch_http_publish_host is defined %} -http.publish_host: "{{ ealsticsearch_http_publish_host }}" +{% if elasticsearch_http_publish_host is defined %} +http.publish_host: "{{ elasticsearch_http_publish_host }}" {% endif %} {% if ealsticsearch_http_publish_port is defined %} http.publish_port: {{ ealsticsearch_http_publish_port }} From 57245453e8b5c044c926e1b689455a108a0b9faa Mon Sep 17 00:00:00 2001 From: dnssmr Date: Thu, 10 Aug 2023 12:50:49 +0200 Subject: [PATCH 2/2] fixed ealsticsearch_http_publish_port safely --- docs/role-elasticsearch.md | 2 +- roles/elasticsearch/templates/elasticsearch.yml.j2 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/role-elasticsearch.md b/docs/role-elasticsearch.md index e9e5add3..a53410a3 100644 --- a/docs/role-elasticsearch.md +++ b/docs/role-elasticsearch.md @@ -32,7 +32,7 @@ Role Variables * *elasticsearch_bootstrap_pw*: Bootstrap password for Elasticsearch (Default: `PleaseChangeMe`) * *elasticsearch_disable_systemcallfilterchecks*: Disable system call filter checks. This has a security impact but is necessary on some systems. Please refer to the [docs](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/_system_call_filter_check.html) for details. (default: `false`) * *elasticsearch_http_publish_host*: (String) The network address for HTTP clients to contact the node using sniffing. Accepts an IP address, a hostname, or a special value. (default: `not set`) -* *ealsticsearch_http_publish_port*: (integer) The port of the HTTP publish address. Configure this setting only if you need the publish port to be different from http.port. (default: `not set`) +* *elasticsearch_http_publish_port*: (integer) The port of the HTTP publish address. Configure this setting only if you need the publish port to be different from http.port. (default: `not set`) * *elasticsearch_pamlimits*: Set pam_limits neccessary for Elasticsearch. (Default: `true`) * *elasticsearch_check_calculation*: End play in checks (Default: `false`) diff --git a/roles/elasticsearch/templates/elasticsearch.yml.j2 b/roles/elasticsearch/templates/elasticsearch.yml.j2 index de21f7fe..d059726c 100644 --- a/roles/elasticsearch/templates/elasticsearch.yml.j2 +++ b/roles/elasticsearch/templates/elasticsearch.yml.j2 @@ -6,8 +6,8 @@ network.host: ["_local_","_site_"] {% if elasticsearch_http_publish_host is defined %} http.publish_host: "{{ elasticsearch_http_publish_host }}" {% endif %} -{% if ealsticsearch_http_publish_port is defined %} -http.publish_port: {{ ealsticsearch_http_publish_port }} +{% if elasticsearch_http_publish_port is defined %} +http.publish_port: {{ elasticsearch_http_publish_port }} {% endif %} {% if elasticsearch_node_types is defined %}