From 2ab9bbeb1a4f9830956f00bddbe970c034c9cf63 Mon Sep 17 00:00:00 2001 From: Donien <88634789+Donien@users.noreply.github.com> Date: Mon, 15 Sep 2025 15:37:26 +0200 Subject: [PATCH] Fix modules not being installed when disabled Fixes #404 --- changelogs/fragments/fix-404-disabled-modules.yml | 4 ++++ roles/icingaweb2/tasks/main.yml | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/fix-404-disabled-modules.yml diff --git a/changelogs/fragments/fix-404-disabled-modules.yml b/changelogs/fragments/fix-404-disabled-modules.yml new file mode 100644 index 00000000..4e98394b --- /dev/null +++ b/changelogs/fragments/fix-404-disabled-modules.yml @@ -0,0 +1,4 @@ +bugfixes: + - | + Fix issue where the package for any given Icinga Web 2 module was not installed if that module had set :code:`enabled: false`. + Modules are now installed and configured properly even when they are set to be disabled in the end. diff --git a/roles/icingaweb2/tasks/main.yml b/roles/icingaweb2/tasks/main.yml index f0530de9..cb4c2aa7 100644 --- a/roles/icingaweb2/tasks/main.yml +++ b/roles/icingaweb2/tasks/main.yml @@ -28,7 +28,10 @@ loop: "{{ icingaweb2_modules | dict2items }}" loop_control: label: "{{ item.key }}" - when: icingaweb2_modules is defined and icingaweb2_module_packages[item.key] is defined and item.value.enabled | bool == true and item.value.source == "package" + when: + - icingaweb2_modules is defined + - icingaweb2_module_packages[item.key] is defined + - item.value.source == "package" no_log: true - name: Check supported operatingsystems