Skip to content

Conversation

@martialblog
Copy link
Member

@martialblog martialblog commented Nov 13, 2024

See #15

@martialblog martialblog self-assigned this Nov 13, 2024
@martialblog martialblog added this to the Release of Fork milestone Nov 13, 2024
@martialblog
Copy link
Member Author

Mainly white-space or indentation issues. Can be fixed once we merge in open PRs to avoid conflicts

Copy link
Contributor

@tbauriedel tbauriedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent checked all *.php files.
But based on the linter workflows and the successful checks, I would say it works!

@martialblog
Copy link
Member Author

I want to wait with the merge if we want to include existing Pull Requests this change here might cause conflicts.

We can just run phpcbf once everything is merged

@martialblog martialblog marked this pull request as draft November 15, 2024 10:52
@martialblog martialblog marked this pull request as ready for review November 15, 2024 12:38
@martialblog martialblog merged commit 08d523e into main Nov 15, 2024
2 checks passed
@martialblog martialblog deleted the chore/ci branch November 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants