Compiling EventStore with Raven 2.0 (unstable) #147

Closed
georgiosd opened this Issue Dec 19, 2012 · 13 comments

Comments

Projects
None yet
5 participants
@georgiosd

Beyond changing a couple of syntax breaking changes, the Raven persistence doesn't seem to work.

This looks like a regression, since this issue was first reported here: https://groups.google.com/forum/#!msg/ravendb/pHE4VQBTfJI/Ibg8WLfv1IwJ

RavenCommit.Payload is deserialized as DynamicList which makes the (T) cast in DocumentSerializer blow up.

Any guidance as to how to get it fixed would be appreciated.

@georgiosd

This comment has been minimized.

Show comment Hide comment
@georgiosd

georgiosd Dec 19, 2012

OK, here a workaround. Edit RavenCommit.cs:

[Raven.Imports.Newtonsoft.Json.JsonProperty(TypeNameHandling = Raven.Imports.Newtonsoft.Json.TypeNameHandling.All)]
public object Payload { get; set; }

OK, here a workaround. Edit RavenCommit.cs:

[Raven.Imports.Newtonsoft.Json.JsonProperty(TypeNameHandling = Raven.Imports.Newtonsoft.Json.TypeNameHandling.All)]
public object Payload { get; set; }

@kblooie

This comment has been minimized.

Show comment Hide comment
@kblooie

kblooie Dec 19, 2012

Member

Ill take a look at this tomorrow and get a fix out.

On Dec 19, 2012, at 10:35 AM, georgiosd notifications@github.com wrote:

Beyond changing a couple of syntax breaking changes, the Raven persistence
doesn't seem to work.

This looks like a regression, since this issue was first reported here:
https://groups.google.com/forum/#!msg/ravendb/pHE4VQBTfJI/Ibg8WLfv1IwJ

RavenCommit.Payload is deserialized as DynamicList which makes the (T) cast
in DocumentSerializer blow up.

Any guidance as to how to get it fixed would be appreciated.


Reply to this email directly or view it on
GitHubhttps://github.com/joliver/EventStore/issues/147.

Member

kblooie commented Dec 19, 2012

Ill take a look at this tomorrow and get a fix out.

On Dec 19, 2012, at 10:35 AM, georgiosd notifications@github.com wrote:

Beyond changing a couple of syntax breaking changes, the Raven persistence
doesn't seem to work.

This looks like a regression, since this issue was first reported here:
https://groups.google.com/forum/#!msg/ravendb/pHE4VQBTfJI/Ibg8WLfv1IwJ

RavenCommit.Payload is deserialized as DynamicList which makes the (T) cast
in DocumentSerializer blow up.

Any guidance as to how to get it fixed would be appreciated.


Reply to this email directly or view it on
GitHubhttps://github.com/joliver/EventStore/issues/147.

@kblooie

This comment has been minimized.

Show comment Hide comment
@kblooie

kblooie Dec 19, 2012

Member

Sweet! If you submit the patch req, ill test it out.

On Dec 19, 2012, at 10:39 AM, georgiosd notifications@github.com wrote:

OK, here a workaround. Edit RavenCommit.cs:

[Raven.Imports.Newtonsoft.Json.JsonProperty(TypeNameHandling =
Raven.Imports.Newtonsoft.Json.TypeNameHandling.All)]
public object Payload { get; set; }


Reply to this email directly or view it on
GitHubhttps://github.com/joliver/EventStore/issues/147#issuecomment-11537049.

Member

kblooie commented Dec 19, 2012

Sweet! If you submit the patch req, ill test it out.

On Dec 19, 2012, at 10:39 AM, georgiosd notifications@github.com wrote:

OK, here a workaround. Edit RavenCommit.cs:

[Raven.Imports.Newtonsoft.Json.JsonProperty(TypeNameHandling =
Raven.Imports.Newtonsoft.Json.TypeNameHandling.All)]
public object Payload { get; set; }


Reply to this email directly or view it on
GitHubhttps://github.com/joliver/EventStore/issues/147#issuecomment-11537049.

@georgiosd

This comment has been minimized.

Show comment Hide comment
@georgiosd

georgiosd Dec 19, 2012

Thanks for the prompt response. Not really worth doing a pull request for just one line of code :)
Not that I mind, but I haven't acquainted myself with git just yet...

But, I believe it's because of the way Raven now handles references to JSON.NET - they used to reference a specific version of JSON.NET which made sure nothing would break between versions but created problems when you had another library that referenced another version of JSON.NET. It seems that they import the whole thing in their own namespace to overcome this.

Thanks for the prompt response. Not really worth doing a pull request for just one line of code :)
Not that I mind, but I haven't acquainted myself with git just yet...

But, I believe it's because of the way Raven now handles references to JSON.NET - they used to reference a specific version of JSON.NET which made sure nothing would break between versions but created problems when you had another library that referenced another version of JSON.NET. It seems that they import the whole thing in their own namespace to overcome this.

@serra

This comment has been minimized.

Show comment Hide comment
@serra

serra Dec 19, 2012

Contributor

You can edit and send a pull request through your browser on github, just navigate to the file and hit edit. Hth, Marijn.

Contributor

serra commented Dec 19, 2012

You can edit and send a pull request through your browser on github, just navigate to the file and hit edit. Hth, Marijn.

@georgiosd

This comment has been minimized.

Show comment Hide comment
@georgiosd

georgiosd Dec 20, 2012

Sweet lord. Thanks for educating the newbie serra :)

Sweet lord. Thanks for educating the newbie serra :)

@serra

This comment has been minimized.

Show comment Hide comment
@serra

serra Dec 20, 2012

Contributor

I ❤️ github 😄
And have you noticed noticed the cross reference to this issue?

Contributor

serra commented Dec 20, 2012

I ❤️ github 😄
And have you noticed noticed the cross reference to this issue?

@georgiosd

This comment has been minimized.

Show comment Hide comment
@georgiosd

georgiosd Dec 20, 2012

How does it know?? Because I put a link to this issue over there?

How does it know?? Because I put a link to this issue over there?

@serra

This comment has been minimized.

Show comment Hide comment
@serra

serra Dec 20, 2012

Contributor

yes, it does.

Contributor

serra commented Dec 20, 2012

yes, it does.

@jkonecki

This comment has been minimized.

Show comment Hide comment
@jkonecki

jkonecki Feb 1, 2013

I'm using version 3.1.0.19 of EventStore and RavenPersistence from CodeBetter TeamCity server (master branch) and still experience the same issue

Unable to cast object of type 'Raven.Abstractions.Linq.DynamicList' to type 'System.Collections.Generic.List`1[EventStore.EventMessage]'.

despite the fact that a change to RavenCommit.cs has been made.

Is this issue supposed to be fixed?
Would appreciate any update...

jkonecki commented Feb 1, 2013

I'm using version 3.1.0.19 of EventStore and RavenPersistence from CodeBetter TeamCity server (master branch) and still experience the same issue

Unable to cast object of type 'Raven.Abstractions.Linq.DynamicList' to type 'System.Collections.Generic.List`1[EventStore.EventMessage]'.

despite the fact that a change to RavenCommit.cs has been made.

Is this issue supposed to be fixed?
Would appreciate any update...

@kblooie

This comment has been minimized.

Show comment Hide comment
@kblooie

kblooie Feb 1, 2013

Member

When are you seeing this issue? When getting an existing stream? When
committing to a new stream? When committing to an existing stream? Could
you provide a failing test?

Jonathan

On Jan 31, 2013, at 8:06 PM, jkonecki notifications@github.com wrote:

I'm using version 3.1.0.19 of EventStore and RavenPersistence from
CodeBetter TeamCity server (master branch) and still experience the same
issue

Unable to cast object of type 'Raven.Abstractions.Linq.DynamicList' to type
'System.Collections.Generic.List`1[EventStore.EventMessage]'.

despite the fact that a change to RavenCommit.cs has been made.

Is this issue supposed to be fixed?
Would appreciate any update...


Reply to this email directly or view it on
GitHubhttps://github.com/joliver/EventStore/issues/147#issuecomment-12977228.

Member

kblooie commented Feb 1, 2013

When are you seeing this issue? When getting an existing stream? When
committing to a new stream? When committing to an existing stream? Could
you provide a failing test?

Jonathan

On Jan 31, 2013, at 8:06 PM, jkonecki notifications@github.com wrote:

I'm using version 3.1.0.19 of EventStore and RavenPersistence from
CodeBetter TeamCity server (master branch) and still experience the same
issue

Unable to cast object of type 'Raven.Abstractions.Linq.DynamicList' to type
'System.Collections.Generic.List`1[EventStore.EventMessage]'.

despite the fact that a change to RavenCommit.cs has been made.

Is this issue supposed to be fixed?
Would appreciate any update...


Reply to this email directly or view it on
GitHubhttps://github.com/joliver/EventStore/issues/147#issuecomment-12977228.

@jkonecki

This comment has been minimized.

Show comment Hide comment
@jkonecki

jkonecki Feb 1, 2013

The exception was thrown from Wireup.Build() method with the existing database.

I upgraded my Raven server from 1.0 (960) to the latest 2.0 (2230) build and CommonDomain/EventStore assemblies.
I suspect the issue occurs during the check for any undispatched commits.

After I've deleted the database (I'm working now on a tool for my project for data migration from legacy SQL server to EventStore) and recreated all the streams all was fine.

I'm pretty sure I've rebuiilt the whole solution and checked that I don't have old NuGet packages lying around.

If you can't proceed with the above let me know and I'll get the old version of RavenDB server, recreate the database and try the upgrade again during weekend.

jkonecki commented Feb 1, 2013

The exception was thrown from Wireup.Build() method with the existing database.

I upgraded my Raven server from 1.0 (960) to the latest 2.0 (2230) build and CommonDomain/EventStore assemblies.
I suspect the issue occurs during the check for any undispatched commits.

After I've deleted the database (I'm working now on a tool for my project for data migration from legacy SQL server to EventStore) and recreated all the streams all was fine.

I'm pretty sure I've rebuiilt the whole solution and checked that I don't have old NuGet packages lying around.

If you can't proceed with the above let me know and I'll get the old version of RavenDB server, recreate the database and try the upgrade again during weekend.

@ghost ghost assigned kblooie May 9, 2013

@damianh

This comment has been minimized.

Show comment Hide comment
@damianh

damianh Jun 21, 2013

Contributor

@kblooie This could probably be closed for 3.2?

Contributor

damianh commented Jun 21, 2013

@kblooie This could probably be closed for 3.2?

@kblooie kblooie closed this Jun 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment