Skip to content

Commit 3ad5674

Browse files
feat(module:collapse): change nzExpandIconPosition type from left | right to start | end (#8561)
* fix(module:collapse): fix nzExpandIconPosition type * docs: update docs
1 parent f668b87 commit 3ad5674

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

components/collapse/collapse.component.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ const NZ_CONFIG_MODULE_NAME: NzConfigKey = 'collapse';
3131
template: ` <ng-content></ng-content> `,
3232
host: {
3333
class: 'ant-collapse',
34-
'[class.ant-collapse-icon-position-start]': `nzExpandIconPosition === 'left'`,
35-
'[class.ant-collapse-icon-position-end]': `nzExpandIconPosition === 'right'`,
34+
'[class.ant-collapse-icon-position-start]': `nzExpandIconPosition === 'start'`,
35+
'[class.ant-collapse-icon-position-end]': `nzExpandIconPosition === 'end'`,
3636
'[class.ant-collapse-ghost]': `nzGhost`,
3737
'[class.ant-collapse-borderless]': '!nzBordered',
3838
'[class.ant-collapse-rtl]': "dir === 'rtl'"
@@ -46,8 +46,7 @@ export class NzCollapseComponent implements OnInit {
4646
@Input({ transform: booleanAttribute }) @WithConfig() nzAccordion: boolean = false;
4747
@Input({ transform: booleanAttribute }) @WithConfig() nzBordered: boolean = true;
4848
@Input({ transform: booleanAttribute }) @WithConfig() nzGhost: boolean = false;
49-
// TODO(v18): change 'left' | 'right' to 'start' | 'end, it's gonna be a break changing.
50-
@Input() nzExpandIconPosition: 'left' | 'right' = 'left';
49+
@Input() nzExpandIconPosition: 'start' | 'end' = 'start';
5150

5251
dir: Direction = 'ltr';
5352

components/collapse/demo/extra.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ import { Component } from '@angular/core';
2525
<br />
2626
<span>Expand Icon Position: </span>
2727
<nz-select [(ngModel)]="expandIconPosition">
28-
<nz-option nzValue="left" nzLabel="left"></nz-option>
29-
<nz-option nzValue="right" nzLabel="right"></nz-option>
28+
<nz-option nzValue="start" nzLabel="start"></nz-option>
29+
<nz-option nzValue="end" nzLabel="end"></nz-option>
3030
</nz-select>
3131
`
3232
})
3333
export class NzDemoCollapseExtraComponent {
34-
expandIconPosition: 'left' | 'right' = 'left';
34+
expandIconPosition: 'start' | 'end' = 'start';
3535

3636
panels = [
3737
{

components/collapse/doc/index.en-US.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { NzCollapseModule } from 'ng-zorro-antd/collapse';
2626
| `[nzAccordion]` | Accordion mode | `boolean` | `false` ||
2727
| `[nzBordered]` | Set border style | `boolean` | `true` ||
2828
| `[nzGhost]` | Make the collapse borderless and its background transparent | `boolean` | `false` ||
29-
| `[nzExpandIconPosition]` | Set expand icon position | `'left' \| 'right'` | `left` | - |
29+
| `[nzExpandIconPosition]` | Set expand icon position | `'start' \| 'end'` | `start` | - |
3030

3131
### nz-collapse-panel:standalone
3232

components/collapse/doc/index.zh-CN.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { NzCollapseModule } from 'ng-zorro-antd/collapse';
2727
| `[nzAccordion]` | 是否每次只打开一个 tab | `boolean` | `false` ||
2828
| `[nzBordered]` | 是否有边框 | `boolean` | `true` ||
2929
| `[nzGhost]` | 使折叠面板透明且无边框 | `boolean` | `false` ||
30-
| `[nzExpandIconPosition]` | 设置图标位置 | `'left' \| 'right'` | `left` | - |
30+
| `[nzExpandIconPosition]` | 设置图标位置 | `'start' \| 'end'` | `start` | - |
3131

3232
### nz-collapse-panel:standalone
3333

0 commit comments

Comments
 (0)