[nz-code-editor] Configure MonacoEnvironment before (first) load

[Airblader]

What problem does this feature solve?

Since monaco-editor 0.22.0¹, the global monaco object is only defined if you add

window.MonacoEnvironment = { globalAPI: true };

It would be nice if ng-zorro had some hook to configure MonacoEnvironment (also for potential other use-cases) before monaco-editor is actually loaded. Also, the documentation for onLoad is now slightly incorrect/incomplete:

The hook invoked when the resource of monaco editor is loaded. At this moment and afterwards the global variable monaco is usable

¹ https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md

What does the proposed API look like?

Extend NzConfig#codeEditor with either an object or a function to modify MonacoEnvironment.

[zorro-bot]

Hello @Airblader. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @Airblader, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板，提供改动所需相应的测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！

[thekhegay]

@hullis @simplejason

"ng-zorro-antd": "^13.2.0",

Error: node_modules/ng-zorro-antd/core/config/config.d.ts:9:29 - error TS2307: Cannot find module 'monaco-editor' or its corresponding type declarations.

import { Environment } from 'monaco-editor';

[anthoniriv]

@hullis @simplejason

"ng-zorro-antd": "^13.2.0",

Error: node_modules/ng-zorro-antd/core/config/config.d.ts:9:29 - error TS2307: Cannot find module 'monaco-editor' or its corresponding type declarations.



import { Environment } from 'monaco-editor';

Did you fix it? Same problem here

[wzhudev]

Hi @thekhegay. Have you installed the monaco-editor package? ng-zorro-antd does not list monaco-editor as a dependency for some reason (monaco-editor component is an experimental component). Sorry, seems a problem on our side.

[anthoniriv]

I had to install monaco-editor to solve the problem idk why. I don't use it

[wzhudev]

I had to install monaco-editor to solve the problem idk why. I don't use it

For sorry that. The problem is on our side. We will fix it soon.

[wzhudev]

ng-zorro-antd/components/core/config/config.ts

Line 11 in 99f4141

import { Environment } from 'monaco-editor';

@yangjunhan Should not import type declaration here. Forcing all users to install monaco-editor.

[thekhegay]

@hullis any updates?

[wzhudev]

@hullis any updates?

This problem should have been fixed in our recent release.