New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support service to create drawer #1981

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
3 participants
@HsuanXyz
Member

HsuanXyz commented Aug 13, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1937

What is the new behavior?

support service

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov

This comment has been minimized.

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1981 into master will increase coverage by 0.01%.
The diff coverage is 98.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
+ Coverage      96%   96.02%   +0.01%     
==========================================
  Files         479      481       +2     
  Lines       11697    11817     +120     
  Branches     1564     1575      +11     
==========================================
+ Hits        11230    11347     +117     
  Misses        132      132              
- Partials      335      338       +3
Impacted Files Coverage Δ
...ents/core/services/nz-measure-scrollbar.service.ts 81.81% <ø> (ø) ⬆️
...ts/core/overlay/scroll/nz-block-scroll-strategy.ts 100% <100%> (ø) ⬆️
components/drawer/nz-drawer-ref.ts 100% <100%> (ø)
components/drawer/nz-drawer.service.ts 100% <100%> (ø)
components/drawer/nz-drawer.module.ts 100% <100%> (ø) ⬆️
.../core/overlay/scroll/nz-scroll-strategy-options.ts 100% <100%> (ø) ⬆️
components/drawer/nz-drawer.component.ts 97.45% <97.91%> (+0.01%) ⬆️
components/table/nz-table.component.ts 95% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c5210...ec98543. Read the comment docs.

@xingkoo

This comment has been minimized.

xingkoo commented Aug 16, 2018

Thanks, expectations

@HsuanXyz HsuanXyz force-pushed the HsuanXyz:drawer/feat-service branch from 6af4148 to a7d7205 Aug 19, 2018

@HsuanXyz HsuanXyz changed the title from WIP(module:drawer): support service to create drawer to feat(module:drawer): support service to create drawer Aug 19, 2018

@HsuanXyz HsuanXyz requested a review from vthinkxie Aug 19, 2018

}
}
@Injectable()

This comment has been minimized.

@vthinkxie

vthinkxie Sep 7, 2018

Member

provideIn:root

@xingkoo

This comment has been minimized.

xingkoo commented Sep 17, 2018

@HsuanXyz Conflicting files. i hope it can be used as fast. thanks very much

@HsuanXyz HsuanXyz force-pushed the HsuanXyz:drawer/feat-service branch 4 times, most recently from 132a615 to b30da11 Sep 20, 2018

@HsuanXyz HsuanXyz force-pushed the HsuanXyz:drawer/feat-service branch from b30da11 to ec98543 Sep 21, 2018

@vthinkxie vthinkxie merged commit a232d59 into NG-ZORRO:master Sep 21, 2018

4 checks passed

codecov/patch 98.56% of diff hit (target 96%)
Details
codecov/project 96.02% (+0.01%) compared to 69c5210
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@HsuanXyz HsuanXyz deleted the HsuanXyz:drawer/feat-service branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment