New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): add version number validation and rename script #2117

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@wendzhue
Member

wendzhue commented Sep 9, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: modify publish script

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Add version number validation check. Rename npm script because npm publish command would run npm run publish as well, throwing error unreasonably.

@codecov

This comment has been minimized.

codecov bot commented Sep 9, 2018

Codecov Report

Merging #2117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2117   +/-   ##
======================================
  Coverage      96%     96%           
======================================
  Files         477     477           
  Lines       11618   11618           
  Branches     1550    1550           
======================================
  Hits        11154   11154           
  Misses        132     132           
  Partials      332     332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fde383...ad14130. Read the comment docs.

@vthinkxie vthinkxie merged commit bc1f6fa into NG-ZORRO:master Sep 17, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 2fde383...ad14130
Details
codecov/project 96% remains the same compared to 2fde383
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@wendzhue wendzhue deleted the wendzhue:publish branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment