New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): drawer content cannot scroll #2120

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@HsuanXyz
Member

HsuanXyz commented Sep 10, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2119

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov

This comment has been minimized.

codecov bot commented Sep 10, 2018

Codecov Report

Merging #2120 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
- Coverage      96%   95.99%   -0.01%     
==========================================
  Files         477      477              
  Lines       11618    11618              
  Branches     1550     1550              
==========================================
- Hits        11154    11153       -1     
  Misses        132      132              
- Partials      332      333       +1
Impacted Files Coverage Δ
components/tabs/nz-tabset.component.ts 95.72% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fde383...71905e3. Read the comment docs.

@HsuanXyz HsuanXyz force-pushed the HsuanXyz:drawer/fix-content-scroll branch from 71905e3 to 877dbb5 Sep 15, 2018

@vthinkxie vthinkxie merged commit e8dad8f into NG-ZORRO:master Sep 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@HsuanXyz HsuanXyz deleted the HsuanXyz:drawer/fix-content-scroll branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment