New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): no HttpClient exception typo #2173

merged 1 commit into from Sep 21, 2018


None yet
3 participants

Tibing commented Sep 20, 2018

Fix typo in exception if no HttpClient provided

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If application doesn't import HttpClientModule the NzUploadBtnComponent throw exception which says HttpClientModel is not provided.

What is the new behavior?

Exception should say that HttpClientModule is not provided.

Does this PR introduce a breaking change?

[ ] Yes
[x] No
fix(upload): fix typo
Fix typo in exception if no HttpClient provided

This comment has been minimized.

codecov bot commented Sep 20, 2018

Codecov Report

Merging #2173 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2173   +/-   ##
  Coverage      96%     96%           
  Files         479     479           
  Lines       11697   11697           
  Branches     1564    1564           
  Hits        11230   11230           
  Misses        132     132           
  Partials      335     335
Impacted Files Coverage Δ
components/upload/nz-upload-btn.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ff576...cc7ea91. Read the comment docs.

@vthinkxie vthinkxie merged commit 69c5210 into NG-ZORRO:master Sep 21, 2018

4 checks passed

codecov/patch 100% of diff hit (target 96%)
codecov/project 96% (+0%) compared to 69ff576
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment