Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module:statistic): add statistic and countdown component #2760

Merged
merged 2 commits into from Feb 25, 2019
Merged

feat(module:statistic): add statistic and countdown component #2760

merged 2 commits into from Feb 25, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 9, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2754

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 9, 2019 •
edited

Codecov Report

Merging #2760 into master will decrease coverage by 0.02%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
- Coverage   97.39%   97.37%   -0.03%     
==========================================
  Files         537      545       +8     
  Lines       11168    11260      +92     
  Branches      805      809       +4     
==========================================
+ Hits        10877    10964      +87     
- Misses        183      188       +5     
  Partials      108      108
Impacted Files Coverage Δ
components/icon/nz-icon.service.ts 100% <ø> (ø) ⬆️
components/statistic/nz-statistic-definitions.ts 100% <100%> (ø)
components/statistic/nz-statistic.module.ts 100% <100%> (ø)
components/statistic/nz-statistic.component.ts 100% <100%> (ø)
...ponents/statistic/nz-statistic-number.component.ts 100% <100%> (ø)
components/statistic/nz-time-range.pipe.ts 100% <100%> (ø)
components/core/util/time.ts 100% <100%> (ø)
components/core/util/public-api.ts 100% <100%> (ø) ⬆️
components/core/util/string.ts 77.77% <77.77%> (ø)
components/statistic/nz-countdown.component.ts 93.54% <93.54%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d68e44...26efa18. Read the comment docs.

@netlify
Copy link

netlify bot commented Jan 9, 2019 •
edited

Deploy preview for ng-zorro-master ready!

Built with commit 26efa18

https://deploy-preview-2760--ng-zorro-master.netlify.com

@wzhudev wzhudev changed the title WIP(module:statistic): add statistic and countdown component feat(module:statistic): add statistic and countdown component Jan 12, 2019
hsuanxyz
hsuanxyz requested changes Jan 15, 2019
View reviewed changes
components/statistic/doc/index.en-US.md Outdated Show resolved Hide resolved
components/statistic/doc/index.en-US.md Outdated Show resolved Hide resolved
components/statistic/nz-number.component.ts Outdated Show resolved Hide resolved
components/statistic/nz-statistic.component.ts Outdated Show resolved Hide resolved
components/core/util/string.ts Outdated Show resolved Hide resolved
components/statistic/doc/index.en-US.md Outdated Show resolved Hide resolved
components/statistic/doc/index.en-US.md Outdated Show resolved Hide resolved
components/statistic/doc/index.en-US.md Outdated Show resolved Hide resolved
components/statistic/nz-countdown.component.ts Outdated Show resolved Hide resolved
@wzhudev
Copy link
Member Author

wzhudev commented Jan 15, 2019

@hsuanxyz All fixed. Please review.

@wzhudev
Copy link
Member Author

wzhudev commented Jan 18, 2019

@hsuanxyz Blocked by what?

hsuanxyz
hsuanxyz requested changes Jan 21, 2019
View reviewed changes
components/statistic/nz-countdown.component.ts Outdated Show resolved Hide resolved
components/statistic/nz-statistic-number.component.ts Outdated Show resolved Hide resolved
components/statistic/nz-statistic.component.ts Outdated Show resolved Hide resolved
@wzhudev
Copy link
Member Author

wzhudev commented Jan 28, 2019

Since we are going to change date format string API, this PR should be ready to merge.

@wzhudev wzhudev force-pushed the statistic branch 2 times, most recently from 66da4fd to 0d4caa6 Compare February 25, 2019 03:42
vthinkxie
vthinkxie requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove [nzPrecision] [nzDecimalSeparator] [nzGroupSeparator]
  2. nz-countdown -> nzTimeRangePipe

vthinkxie
vthinkxie approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit abb9ae4 into NG-ZORRO:master Feb 25, 2019
@wzhudev wzhudev mentioned this pull request Feb 25, 2019
Closed
@wzhudev wzhudev deleted the statistic branch February 25, 2019 11:52
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
feat(module:statistic): add statistic and countdown component (NG-ZOR…
ca3c6bf 
…RO#2760)

* feat(module:statistic): add statistic and countdown component

* fix: time range handle undefined value
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@vthinkxie
feat(module:statistic): add statistic and countdown component (NG-ZOR…
bb23726 
…RO#2760)

* feat(module:statistic): add statistic and countdown component

* fix: time range handle undefined value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz

Assignees
No one assigned
Labels
⭐ New Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wzhudev @vthinkxie @hsuanxyz