feat(module:descriptions): add component #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 5402c94 |
Codecov Report
@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
+ Coverage 95.6% 95.67% +0.06%
==========================================
Files 609 690 +81
Lines 13250 13687 +437
Branches 1810 1821 +11
==========================================
+ Hits 12668 13095 +427
- Misses 197 201 +4
- Partials 385 391 +6
Continue to review full report at Codecov.
|
close NG-ZORRO#2847 feat(module:descriptions): rename component & add demo fix: fix un-renamed variables WIP feat(module:descriptions): support responsive
added 2 commits
May 23, 2019 12:23
|
Should be merged after this component is shipped in antd. |
|
I fixed the test for responsive in the grid component. |
hsuanxyz
requested changes
May 24, 2019
hsuanxyz
requested changes
May 24, 2019
| --- | ||
| category: Components | ||
| type: Data Display | ||
| title: Descriptions |
There was a problem hiding this comment.
Suggested change
| title: Descriptions | |
| title: Description List |
hsuanxyz
requested changes
May 24, 2019
added 2 commits
May 25, 2019 12:44
hsuanxyz
requested changes
Jun 4, 2019
hsuanxyz
approved these changes
Jun 4, 2019
simplejason
reviewed
Jun 5, 2019
simplejason
approved these changes
Jun 5, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:descriptions): add component close NG-ZORRO#2847 feat(module:descriptions): rename component & add demo fix: fix un-renamed variables WIP feat(module:descriptions): support responsive * fix: test * fix: test, add responsive test * test: fix grid responsive test by the way * fix: fix typedef of responsiveMap and other fixes * fix: restrict window viewport to pass test * fix: fix * docs: fix docs
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:descriptions): add component close NG-ZORRO#2847 feat(module:descriptions): rename component & add demo fix: fix un-renamed variables WIP feat(module:descriptions): support responsive * fix: test * fix: test, add responsive test * test: fix grid responsive test by the way * fix: fix typedef of responsiveMap and other fixes * fix: restrict window viewport to pass test * fix: fix * docs: fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2847
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2847
What is the new behavior?
Does this PR introduce a breaking change?
Other information