Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:code-editor): add code editor component #3706

Merged
merged 3 commits into from Aug 13, 2019

Conversation

@wendzhue
Copy link
Member

commented Jul 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jul 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #3706 into master will decrease coverage by 0.94%.
The diff coverage is 11.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3706      +/-   ##
=========================================
- Coverage   93.25%   92.3%   -0.95%     
=========================================
  Files         500     506       +6     
  Lines       10615   10749     +134     
  Branches     1924    1941      +17     
=========================================
+ Hits         9899    9922      +23     
- Misses        301     411     +110     
- Partials      415     416       +1
Impacted Files Coverage Δ
components/core/util/tick.ts 0% <0%> (ø)
components/code-editor/nz-code-editor.component.ts 10.81% <10.81%> (ø)
components/code-editor/nz-code-editor.module.ts 100% <100%> (ø)
components/code-editor/nz-code-editor.service.ts 2.08% <2.08%> (ø)
components/code-editor/demo/basic.ts 50% <50%> (ø)
...mponents/code-editor/nz-code-editor.definitions.ts 83.33% <83.33%> (ø)
components/rate/nz-rate.component.ts 93.1% <0%> (-4.6%) ⬇️
components/time-picker/time-holder.ts 96.49% <0%> (-0.88%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d27fb6...0991f23. Read the comment docs.

@wendzhue wendzhue requested a review from vthinkxie Jul 2, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 2, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0991f23

https://deploy-preview-3706--ng-zorro-master.netlify.com

@wendzhue wendzhue marked this pull request as ready for review Jul 2, 2019

@pr-triage pr-triage bot added PR: unreviewed and removed PR: draft labels Jul 2, 2019

@wendzhue wendzhue referenced this pull request Jul 3, 2019

Open

new components #3701

3 of 8 tasks complete

@wendzhue wendzhue force-pushed the wendzhue:migrate-plus-code-editor branch from 386952d to 093daf3 Jul 19, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jul 19, 2019

@wendzhue wendzhue removed the 🤚 Blocked label Jul 19, 2019

@wendzhue wendzhue force-pushed the wendzhue:migrate-plus-code-editor branch from 093daf3 to b433abb Jul 23, 2019

@wendzhue wendzhue force-pushed the wendzhue:migrate-plus-code-editor branch from b433abb to cbdf492 Aug 12, 2019

Show resolved Hide resolved components/components.less Outdated

@wendzhue wendzhue force-pushed the wendzhue:migrate-plus-code-editor branch from cbdf492 to 8812ce6 Aug 13, 2019

@wendzhue wendzhue force-pushed the wendzhue:migrate-plus-code-editor branch from 3be563a to 0991f23 Aug 13, 2019

@vthinkxie vthinkxie merged commit df78b2e into NG-ZORRO:master Aug 13, 2019

4 of 9 checks passed

codecov/patch 11.94% of diff hit (target 93.25%)
Details
codecov/project 92.3% (-0.95%) compared to 4d27fb6
Details
Header rules No header rules processed
Details
Pages changed 57 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added the PR: merged label Aug 13, 2019

@wendzhue wendzhue deleted the wendzhue:migrate-plus-code-editor branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.