Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:resizable): add resizable component #3771

Merged
merged 10 commits into from Aug 13, 2019

Conversation

@hsuanxyz
Copy link
Member

commented Jul 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3701

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jul 11, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0ba9e6c

https://deploy-preview-3771--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #3771 into master will increase coverage by 0.01%.
The diff coverage is 93.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3771      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files         489      500      +11     
  Lines       10378    10590     +212     
  Branches     1889     1915      +26     
==========================================
+ Hits         9697     9897     +200     
+ Misses        279      278       -1     
- Partials      402      415      +13
Impacted Files Coverage Δ
components/resizable/demo/lock-aspect-ratio.ts 100% <100%> (ø)
components/resizable/demo/customize.ts 100% <100%> (ø)
components/resizable/nz-resizable.module.ts 100% <100%> (ø)
components/resizable/demo/basic.ts 100% <100%> (ø)
components/resizable/demo/preview.ts 100% <100%> (ø)
components/resizable/nz-resizable.service.ts 100% <100%> (ø)
components/resizable/nz-resize-handle.component.ts 100% <100%> (ø)
components/core/util/ensure-in-bounds.ts 100% <100%> (ø)
components/resizable/demo/grid.ts 100% <100%> (ø)
...omponents/resizable/nz-resize-handles.component.ts 83.33% <83.33%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeccb20...0ba9e6c. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:new/resizable branch 2 times, most recently from 18637bc to 6af1c9a Jul 12, 2019

@hsuanxyz hsuanxyz marked this pull request as ready for review Jul 15, 2019

@pr-triage pr-triage bot added PR: unreviewed and removed PR: draft labels Jul 15, 2019

@hsuanxyz hsuanxyz requested a review from vthinkxie Jul 15, 2019

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:new/resizable branch 2 times, most recently from 2f389b2 to 45cfbfc Jul 19, 2019

@wendzhue
Copy link
Member

left a comment

This component is on 🔥🔥🔥 but we can still improve it.

@vthinkxie vthinkxie assigned wendzhue and unassigned vthinkxie Jul 26, 2019

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:new/resizable branch from 45cfbfc to 46ad09a Aug 9, 2019

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:new/resizable branch 2 times, most recently from 7b66d64 to 4fa4e8b Aug 12, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Aug 12, 2019

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:new/resizable branch from 6a5aa88 to 0ba9e6c Aug 13, 2019

@vthinkxie vthinkxie merged commit 5e71739 into NG-ZORRO:master Aug 13, 2019

4 of 9 checks passed

CodeFactor 2 issues found.
Details
codecov/patch 93.39% of diff hit (target 93.43%)
Details
Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 93.45% (+0.01%) compared to aeccb20
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added the PR: merged label Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.