Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:message): fix container instance not destroyed in HMR #3859

Merged
merged 4 commits into from Aug 9, 2019

Conversation

@wendzhue
Copy link
Member

commented Jul 24, 2019

close #3845

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3845

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wendzhue wendzhue requested a review from cipchk Jul 24, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jul 24, 2019

@wendzhue

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

@cipchk You can try to build from this PR and run it with your demo. It should work now.

Screen Shot 2019-07-24 at 11 34 16 PM

@cipchk

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@wendzhue Yes, already working in HMR mode (includes other projects).

@codecov

This comment has been minimized.

Copy link

commented Jul 25, 2019

Codecov Report

Merging #3859 into master will decrease coverage by 0.12%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
- Coverage   95.36%   95.24%   -0.13%     
==========================================
  Files         723      727       +4     
  Lines       14722    14694      -28     
  Branches     1937     1914      -23     
==========================================
- Hits        14040    13995      -45     
- Misses        249      260      +11     
- Partials      433      439       +6
Impacted Files Coverage Δ
components/message/nz-message-base.service.ts 97.43% <100%> (+0.13%) ⬆️
components/message/nz-message.service.ts 100% <100%> (ø) ⬆️
components/core/services/public-api.ts 100% <100%> (ø) ⬆️
components/notification/nz-notification.service.ts 100% <100%> (ø) ⬆️
components/core/logger/logger.ts 52.63% <100%> (ø) ⬆️
components/core/services/nz-singleton.service.ts 94.11% <94.11%> (ø)
components/form/nz-form-item.component.ts 86.84% <0%> (-10.04%) ⬇️
components/tooltip/nz-tooltip.component.ts 88.88% <0%> (-1.59%) ⬇️
components/tabs/nz-tabs-nav.component.ts 89.88% <0%> (-1.08%) ⬇️
components/slider/nz-slider-marks.component.ts 89.74% <0%> (-0.74%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4de8ff...966e368. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Jul 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 966e368

https://deploy-preview-3859--ng-zorro-master.netlify.com

@wendzhue wendzhue requested a review from hsuanxyz Jul 25, 2019

wendzhue added some commits Aug 5, 2019

@vthinkxie
Copy link
Member

left a comment

LGTM

@wendzhue wendzhue changed the title fix(module:message): fix container instance not exposed fix(module:message): fix container instance not destroyed in HMR Aug 9, 2019

@wendzhue wendzhue merged commit 07e86a5 into NG-ZORRO:master Aug 9, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch 96.77% of diff hit (target 95.36%)
Details
codecov/project Absolute coverage decreased by -0.12% but relative coverage increased by +1.4% compared to c4de8ff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 9, 2019

@wendzhue wendzhue deleted the wendzhue:message-destroy branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.