Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:page-header): add default behavior for the back button #3891

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@hsuanxyz
Copy link
Member

commented Jul 30, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3421

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Jul 30, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 30, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 024c82a

https://deploy-preview-3891--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Jul 30, 2019

Codecov Report

Merging #3891 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3891      +/-   ##
==========================================
+ Coverage   95.23%   95.24%   +<.01%     
==========================================
  Files         726      726              
  Lines       14672    14676       +4     
  Branches     1910     1911       +1     
==========================================
+ Hits        13973    13978       +5     
  Misses        260      260              
+ Partials      439      438       -1
Impacted Files Coverage Δ
components/page-header/nz-page-header.component.ts 100% <100%> (ø) ⬆️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ffee2...024c82a. Read the comment docs.

@wendzhue
Copy link
Member

left a comment

lgtm

@wendzhue wendzhue merged commit 41bc285 into NG-ZORRO:master Aug 9, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor 1 issue fixed.
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 95.23%)
Details
codecov/project 95.24% (+<.01%) compared to 39ffee2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.