Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): keep the time value while clicking date #3911

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@wenqi73
Copy link
Member

commented Aug 2, 2019

close #2576, close #1949

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 2, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 2, 2019

Deploy preview for ng-zorro-master ready!

Built with commit da5e3fd

https://deploy-preview-3911--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #3911 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3911      +/-   ##
==========================================
+ Coverage   95.24%   95.24%   +<.01%     
==========================================
  Files         726      726              
  Lines       14672    14672              
  Branches     1910     1909       -1     
==========================================
+ Hits        13974    13975       +1     
  Misses        260      260              
+ Partials      438      437       -1
Impacted Files Coverage Δ
components/calendar/date-table.component.ts 94.49% <100%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31dbe1a...da5e3fd. Read the comment docs.

@wenqi73 wenqi73 requested a review from wendzhue Aug 2, 2019

.setMonth(value.getMonth())
.setDate(value.getDate());

if (this.value !== newValue) {

This comment has been minimized.

Copy link
@wendzhue

wendzhue Aug 2, 2019

Member

CandyDatesetxxx 方法返回的都是新的实例,判断总会是 false

@wenqi73 wenqi73 force-pushed the wenqi73:fix-datepicker-time branch from 3309a7e to da5e3fd Aug 6, 2019

@vthinkxie
Copy link
Member

left a comment

LGTM

@wendzhue

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

This should be a fix.

@wenqi73 wenqi73 changed the title chore(module:date-picker): keep the time value while clicking date fix(module:date-picker): keep the time value while clicking date Aug 7, 2019

@wenqi73 wenqi73 merged commit 9499aec into NG-ZORRO:master Aug 8, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor 1 issue fixed. 1 issue found.
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 95.24%)
Details
codecov/project 95.24% (+<.01%) compared to 31dbe1a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.