Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:timeline): add gray as a default color #3922

Merged
merged 4 commits into from Aug 9, 2019

Conversation

@wendzhue
Copy link
Member

commented Aug 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

It works with the latest style update #3921.

@pr-triage pr-triage bot added the PR: unreviewed label Aug 5, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 5, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2424f14

https://deploy-preview-3922--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #3922 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3922   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         777      777           
  Lines       14825    14825           
  Branches     1910     1910           
=======================================
  Hits        14128    14128           
  Misses        260      260           
  Partials      437      437
Impacted Files Coverage Δ
components/core/testing/public-api.ts 100% <ø> (ø) ⬆️
components/timeline/nz-timeline-item.component.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tabset.component.ts 93.19% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583eb77...2424f14. Read the comment docs.

@hsuanxyz
Copy link
Member

left a comment

看上去多了一些奇怪的文件

@wendzhue

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

看上去多了一些奇怪的文件

Oh, fuck vim!

@darshanrampatel

This comment has been minimized.

Copy link

commented Aug 7, 2019

@wendzhue @hsuanxyz Looks like you have used both "grey" and "gray" - only one of these should be used.

@wendzhue

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

@wendzhue @hsuanxyz Looks like you have used both "grey" and "gray" - only one of these should be used.

Hi! Thank you for pointing that out. We have changed all grey to gray.

@wendzhue wendzhue changed the title feat(module:timeline): add grey as a default color feat(module:timeline): add gray as a default color Aug 8, 2019

@vthinkxie
Copy link
Member

left a comment

test failed

@wendzhue wendzhue force-pushed the wendzhue:timeline-gray branch from 3046c82 to 2424f14 Aug 9, 2019

@vthinkxie
Copy link
Member

left a comment

LGTM

@wendzhue wendzhue merged commit f889f34 into NG-ZORRO:master Aug 9, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor 1 issue fixed.
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 95.29%)
Details
codecov/project 95.29% (+0%) compared to 583eb77
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 9, 2019

@wendzhue wendzhue deleted the wendzhue:timeline-gray branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.