Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:steps): support for clickable steps #3934

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@hsuanxyz
Copy link
Member

commented Aug 6, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 6, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 6, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 7f05dee

https://deploy-preview-3934--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #3934 into master will decrease coverage by <.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3934      +/-   ##
==========================================
- Coverage   95.24%   95.23%   -0.01%     
==========================================
  Files         726      727       +1     
  Lines       14672    14693      +21     
  Branches     1910     1913       +3     
==========================================
+ Hits        13974    13993      +19     
- Misses        260      261       +1     
- Partials      438      439       +1
Impacted Files Coverage Δ
components/steps/nz-step.component.ts 97.72% <100%> (+0.5%) ⬆️
components/steps/demo/clickable.ts 83.33% <83.33%> (ø)
components/steps/nz-steps.component.ts 96.77% <92.3%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719dce0...7f05dee. Read the comment docs.

@wendzhue
Copy link
Member

left a comment

lgtm.

我觉得可以写个测试提升下覆盖率?@hsuanxyz

@wendzhue wendzhue merged commit ac866ce into NG-ZORRO:master Aug 9, 2019

4 of 9 checks passed

codecov/patch 92.85% of diff hit (target 95.24%)
Details
codecov/project 95.23% (-0.01%) compared to 719dce0
Details
Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.