Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix nzWidthConfig in nzTemplateMode #3958

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@vthinkxie
Copy link
Member

commented Aug 12, 2019

close #3957

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 12, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 1d79a4f

https://deploy-preview-3958--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #3958 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3958      +/-   ##
==========================================
- Coverage   95.33%   95.33%   -0.01%     
==========================================
  Files         778      778              
  Lines       14868    14868              
  Branches     1916     1916              
==========================================
- Hits        14175    14174       -1     
  Misses        260      260              
- Partials      433      434       +1
Impacted Files Coverage Δ
components/table/nz-table.component.ts 93.08% <ø> (ø) ⬆️
components/time-picker/time-holder.ts 97.26% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904aacb...1d79a4f. Read the comment docs.

@vthinkxie vthinkxie merged commit baab74b into NG-ZORRO:master Aug 12, 2019

5 of 9 checks passed

codecov/project 95.33% (-0.01%) compared to 904aacb
Details
Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch Coverage not affected when comparing 904aacb...1d79a4f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.