Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:slider): support nzTooltipPlacement #4007

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@wendzhue
Copy link
Member

commented Aug 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Users can set the default position of the tooltip by nzTooltipPlacement.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 14, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 14, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f13eece

https://deploy-preview-4007--ng-zorro-master.netlify.com

@wendzhue wendzhue force-pushed the wendzhue:slider-tooltip-position branch 2 times, most recently from c795f86 to 88824c9 Aug 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

Merging #4007 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.02%     
==========================================
  Files         513      513              
  Lines       10796    10800       +4     
  Branches     1954     1955       +1     
==========================================
+ Hits         9966     9972       +6     
+ Misses        411      409       -2     
  Partials      419      419
Impacted Files Coverage Δ
components/slider/nz-slider.component.ts 91.87% <100%> (+0.04%) ⬆️
components/slider/nz-slider-handle.component.ts 95.55% <100%> (+0.1%) ⬆️
...mponents/tooltip/base/nz-tooltip-base.directive.ts 90.81% <100%> (+1.12%) ⬆️
components/popconfirm/nz-popconfirm.directive.ts 100% <100%> (ø) ⬆️
...s/tooltip/base/nz-tooltip-base-legacy.component.ts 100% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66afcf0...f13eece. Read the comment docs.

@wendzhue wendzhue changed the title feat(module:progress): support nzTooltipPlacement feat(module:slider): support nzTooltipPlacement Aug 15, 2019

@wendzhue

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

I don't know how I messed sliderwith progress. Please take care when merging this.

@wendzhue wendzhue force-pushed the wendzhue:slider-tooltip-position branch 3 times, most recently from a0db9e1 to bd0fc8b Aug 23, 2019

feat(module:progress): support nzTooltipPlacement
refactor(module:progress): not use deprecated API internally

@wendzhue wendzhue force-pushed the wendzhue:slider-tooltip-position branch from bd0fc8b to f13eece Sep 9, 2019

@hsuanxyz hsuanxyz merged commit d6a2968 into NG-ZORRO:master Sep 9, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 92.31%)
Details
codecov/project 92.33% (+0.02%) compared to 66afcf0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 9, 2019

@wendzhue wendzhue deleted the wendzhue:slider-tooltip-position branch Sep 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.