Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:resizable): listen document events when resizing start #4021

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@hsuanxyz
Copy link
Member

commented Aug 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 16, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 59bfdcf

https://deploy-preview-4021--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 16, 2019

Codecov Report

Merging #4021 into master will decrease coverage by 0.27%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
- Coverage   92.41%   92.13%   -0.28%     
==========================================
  Files         506      507       +1     
  Lines       10749    10775      +26     
  Branches     1942     1945       +3     
==========================================
- Hits         9934     9928       -6     
- Misses        400      431      +31     
- Partials      415      416       +1
Impacted Files Coverage Δ
components/resizable/nz-resizable-utils.ts 0% <0%> (ø)
components/core/testing/event-objects.ts 85.71% <100%> (ø) ⬆️
components/resizable/nz-resizable.directive.ts 92.05% <100%> (+0.77%) ⬆️
components/resizable/nz-resize-handle.component.ts 100% <100%> (ø) ⬆️
components/resizable/nz-resizable.service.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tabs-ink-bar.directive.ts 60% <0%> (-30%) ⬇️
components/core/scroll/nz-scroll.service.ts 38.29% <0%> (-23.41%) ⬇️
components/checkbox/nz-checkbox-group.component.ts 90.9% <0%> (-9.1%) ⬇️
components/radio/nz-radio.component.ts 93.61% <0%> (-6.39%) ⬇️
components/switch/nz-switch.component.ts 92.68% <0%> (-4.88%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272e32a...59bfdcf. Read the comment docs.

@wendzhue
Copy link
Member

left a comment

LGTM

@wendzhue

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Maybe we can extract dragging logic into an isolated service. May be used by other components in the future.

@hsuanxyz hsuanxyz merged commit 66afcf0 into NG-ZORRO:master Sep 9, 2019

5 of 9 checks passed

CodeFactor 2 issues fixed. 3 issues found.
Details
Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 98.24% of diff hit (target 92.41%)
Details
codecov/project Absolute coverage decreased by -0.27% but relative coverage increased by +5.82% compared to 272e32a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.