Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:steps): support navigation type and nzDisable nzSubtitle #4064

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@hsuanxyz
Copy link
Member

commented Aug 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3931

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 26, 2019

@auto-assign auto-assign bot requested a review from simplejason Aug 26, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit cb6acb4

https://deploy-preview-4064--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:feat/steps-navigation branch from 6c078a7 to 16c2bec Aug 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #4064 into master will decrease coverage by 0.09%.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4064     +/-   ##
========================================
- Coverage    92.4%   92.3%   -0.1%     
========================================
  Files         506     514      +8     
  Lines       10758   10803     +45     
  Branches     1940    1954     +14     
========================================
+ Hits         9941    9972     +31     
- Misses        402     412     +10     
- Partials      415     419      +4
Impacted Files Coverage Δ
components/steps/demo/clickable.ts 75% <100%> (+8.33%) ⬆️
components/steps/nz-steps.component.ts 96.07% <100%> (+0.07%) ⬆️
components/steps/nz-step.component.ts 97.43% <100%> (+0.13%) ⬆️
components/steps/demo/nav.ts 66.66% <66.66%> (ø)
...ents/time-picker/nz-time-picker-panel.component.ts 86.81% <0%> (-5.19%) ⬇️
components/cascader/nz-cascader.component.ts 95.16% <0%> (-0.75%) ⬇️
components/tree/nz-tree-node.component.ts 88.83% <0%> (-0.42%) ⬇️
components/resizable/nz-resize-handle.component.ts 100% <0%> (ø) ⬆️
...mponents/tooltip/base/nz-tooltip-base.component.ts 94.44% <0%> (ø) ⬆️
components/resizable/nz-resizable.service.ts 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ebd46...cb6acb4. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:feat/steps-navigation branch from fc92c20 to dcee746 Aug 27, 2019

@@ -18,7 +18,7 @@ import { Component } from '@angular/core';
})
export class NzDemoStepsClickableComponent {
index = 0;

disable = false;

This comment has been minimized.

Copy link
@wendzhue

wendzhue Sep 6, 2019

Member

清理一下 demo 好了,这个属性没看到有更改,而且也不是 true

或者改成 true 然后用例里反过来测。

@hsuanxyz hsuanxyz merged commit 272dc98 into NG-ZORRO:master Sep 9, 2019

4 of 9 checks passed

codecov/patch 87.5% of diff hit (target 92.4%)
Details
codecov/project 92.3% (-0.1%) compared to d0ebd46
Details
Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.