Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:i18n): support for Romanian locale #4068

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@hsuanxyz
Copy link
Member

commented Aug 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 27, 2019
@auto-assign auto-assign bot requested a review from wenqi73 Aug 27, 2019
@netlify

This comment has been minimized.

Copy link

commented Aug 27, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 26e7f3d

https://deploy-preview-4068--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz force-pushed the hsuanxyz:feat/i18n-romanian branch from 4127051 to 26e7f3d Aug 27, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #4068 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4068      +/-   ##
=========================================
+ Coverage    92.4%   92.4%   +<.01%     
=========================================
  Files         506     510       +4     
  Lines       10758   10762       +4     
  Branches     1940    1940              
=========================================
+ Hits         9941    9945       +4     
  Misses        402     402              
  Partials      415     415
Impacted Files Coverage Δ
components/i18n/languages/date-picker/ro_RO.ts 100% <100%> (ø)
components/i18n/languages/time-picker/ro_RO.ts 100% <100%> (ø)
components/i18n/languages/time-picker/kn_IN.ts 100% <0%> (ø)
components/i18n/languages/date-picker/kn_IN.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ebd46...26e7f3d. Read the comment docs.

Copy link
Member

left a comment

LGTM

@hsuanxyz hsuanxyz merged commit 207e178 into NG-ZORRO:master Sep 6, 2019
6 of 9 checks passed
6 of 9 checks passed
Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 92.4%)
Details
codecov/project 92.4% (+<.01%) compared to d0ebd46
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.