Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): fix selected index not updated #4094

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@wendzhue
Copy link
Member

commented Sep 2, 2019

close #3873

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3873

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Sep 2, 2019

@auto-assign auto-assign bot requested a review from wenqi73 Sep 2, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 2, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a5fca54

https://deploy-preview-4094--ng-zorro-master.netlify.com

@wendzhue wendzhue force-pushed the wendzhue:tab-navigation-first-abnormal branch from 5324bce to a5fca54 Sep 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 2, 2019

Codecov Report

Merging #4094 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4094      +/-   ##
=========================================
+ Coverage    92.4%   92.4%   +<.01%     
=========================================
  Files         506     506              
  Lines       10758   10759       +1     
  Branches     1940    1940              
=========================================
+ Hits         9941    9942       +1     
  Misses        402     402              
  Partials      415     415
Impacted Files Coverage Δ
components/tabs/nz-tabset.component.ts 91.8% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24c482...a5fca54. Read the comment docs.

@wendzhue wendzhue closed this Sep 2, 2019

@wendzhue wendzhue reopened this Sep 2, 2019

@wendzhue wendzhue merged commit 1e76e37 into NG-ZORRO:master Sep 2, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 92.4%)
Details
codecov/project 92.4% (+<.01%) compared to a24c482
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 2, 2019

@wendzhue wendzhue deleted the wendzhue:tab-navigation-first-abnormal branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.