Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:i18n): fix i18n interface and Traditional Chinese #4102

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@wendzhue
Copy link
Member

commented Sep 3, 2019

close #4080

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Sep 3, 2019

@auto-assign auto-assign bot requested a review from cipchk Sep 3, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5a604fe

https://deploy-preview-4102--ng-zorro-master.netlify.com

@hsuanxyz
Copy link
Member

left a comment

close #4080 in commit

@wendzhue

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

close #4080 in commit

My intention is to close that issue after the Russian i18n file gets fixed.

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4642d84

https://deploy-preview-4102--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz merged commit bb9e89f into NG-ZORRO:master Sep 6, 2019

4 of 7 checks passed

Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 6, 2019

@wendzhue wendzhue deleted the wendzhue:i18n branch Sep 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.