Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:editor): fix type any #4105

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@wendzhue
Copy link
Member

commented Sep 3, 2019

close #4099

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Remove any as much as possible in the demo.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Sep 3, 2019

@auto-assign auto-assign bot requested a review from cipchk Sep 3, 2019

@wendzhue wendzhue requested review from vthinkxie and removed request for cipchk Sep 3, 2019

@netlify

This comment has been minimized.

Copy link

commented Sep 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 7c61229

https://deploy-preview-4105--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #4105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4105   +/-   ##
======================================
  Coverage    92.4%   92.4%           
======================================
  Files         506     506           
  Lines       10759   10759           
  Branches     1940    1940           
======================================
  Hits         9942    9942           
  Misses        402     402           
  Partials      415     415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e76e37...7c61229. Read the comment docs.

@wendzhue wendzhue changed the title fix(module:editor): fix type any docs(module:editor): fix type any Sep 4, 2019

@hsuanxyz hsuanxyz merged commit bd720fb into NG-ZORRO:master Sep 6, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch Coverage not affected when comparing 1e76e37...7c61229
Details
codecov/project 92.4% remains the same compared to 1e76e37
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 6, 2019

@wendzhue wendzhue deleted the wendzhue:editor-demo branch Sep 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.