Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:i18n): missing catalan translations added #4116

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@gpalomar
Copy link
Contributor

commented Sep 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Catalan translations were wrong.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Sep 4, 2019
@auto-assign auto-assign bot requested a review from vthinkxie Sep 4, 2019
@hsuanxyz hsuanxyz added the 🌍 i18n label Sep 4, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 4, 2019

Codecov Report

Merging #4116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4116   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         506      506           
  Lines       10761    10761           
  Branches     1952     1952           
=======================================
  Hits         9935     9935           
  Misses        407      407           
  Partials      419      419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c7f8f...2c8223e. Read the comment docs.

@gpalomar

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

I've only added some strings for translations, why can't this pull request be merged?

@netlify

This comment has been minimized.

Copy link

commented Sep 5, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2c8223e

https://deploy-preview-4116--ng-zorro-master.netlify.com

@wendzhue

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@gpalomar Great work! Thank you for opening this PR.

Copy link
Member

left a comment

LGTM

@wenqi73 wenqi73 merged commit c530c74 into NG-ZORRO:master Sep 5, 2019
6 of 9 checks passed
6 of 9 checks passed
Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/patch Coverage not affected when comparing b7c7f8f...2c8223e
Details
codecov/project 92.32% remains the same compared to b7c7f8f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@pr-triage pr-triage bot added the PR: merged label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.