Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): fix [nzAutosize]="true" (#6403) #6409

Merged
merged 1 commit into from Feb 9, 2021

Conversation

lsbbd
Copy link
Contributor

@lsbbd lsbbd commented Feb 5, 2021

close #6403

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6403

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 5, 2021

This preview will be available after the AzureCI is passed.

@lsbbd lsbbd changed the title fix(module:input): fix [nzAutosize]="true" fix(module:input): fix [nzAutosize]="true" (#6403) Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #6409 (cc240e3) into master (340670d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6409      +/-   ##
==========================================
- Coverage   89.88%   89.86%   -0.02%     
==========================================
  Files         478      478              
  Lines       15277    15277              
  Branches     2468     2468              
==========================================
- Hits        13731    13729       -2     
- Misses        929      930       +1     
- Partials      617      618       +1     
Impacted Files Coverage Δ
components/input/autosize.directive.ts 91.86% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340670d...cc240e3. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot for your PR
autosize type should be limited to boolean

private autosize: boolean | AutoSizeType = false;

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 8ca1e5a into NG-ZORRO:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When nz-input componet is [nzAutosize]="true", It is not working!
2 participants