Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:switch): add nzId input #6815

Merged

Conversation

konossow
Copy link
Contributor

@konossow konossow commented Jul 1, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6808

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 1, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #6815 (35109cc) into master (ca2d3eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6815   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files         488      488           
  Lines       15779    15780    +1     
  Branches     2423     2423           
=======================================
+ Hits        14133    14134    +1     
  Misses       1005     1005           
  Partials      641      641           
Impacted Files Coverage Δ
components/switch/switch.component.ts 95.58% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2d3eb...35109cc. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants