Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:affix): fix update position when target resize #6896

Merged
merged 2 commits into from Nov 1, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 30, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 30, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #6896 (40f508f) into master (f5d1de3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 40f508f differs from pull request most recent head 1e0c0fb. Consider uploading reports for the commit 1e0c0fb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6896      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.01%     
==========================================
  Files         489      489              
  Lines       15805    15807       +2     
  Branches     2428     2429       +1     
==========================================
+ Hits        14147    14151       +4     
+ Misses       1016     1015       -1     
+ Partials      642      641       -1     
Impacted Files Coverage Δ
components/affix/affix.component.ts 87.23% <100.00%> (+0.18%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.03% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d1de3...1e0c0fb. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/affix/affix.component.ts Outdated Show resolved Hide resolved
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM now.

@simplejason simplejason merged commit d18a8ae into NG-ZORRO:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affix固钉在滚动条消失时,固定状态没有改变
3 participants