Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): memory leak #7112

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

diyews
Copy link
Contributor

@diyews diyews commented Dec 10, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Fix memory leak.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #7112 (123523a) into master (d9982e9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 123523a differs from pull request most recent head 3e3f24d. Consider uploading reports for the commit 3e3f24d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7112      +/-   ##
==========================================
- Coverage   89.63%   89.60%   -0.04%     
==========================================
  Files         488      488              
  Lines       15873    15875       +2     
  Branches     2584     2584              
==========================================
- Hits        14227    14224       -3     
- Misses       1014     1016       +2     
- Partials      632      635       +3     
Impacted Files Coverage Δ
...ts/auto-complete/autocomplete-trigger.directive.ts 94.79% <100.00%> (+0.06%) ⬆️
components/core/util/text-measure.ts 89.47% <0.00%> (-1.76%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 85.10% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9982e9...3e3f24d. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants