Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:mention): do not trigger change detections if there are no event listeners #7130

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 18, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #7130 (a156afc) into master (a1bbdab) will increase coverage by 0.00%.
The diff coverage is 96.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7130   +/-   ##
=======================================
  Coverage   91.75%   91.76%           
=======================================
  Files         487      487           
  Lines       15981    15999   +18     
  Branches     2600     2602    +2     
=======================================
+ Hits        14664    14681   +17     
  Misses       1005     1005           
- Partials      312      313    +1     
Impacted Files Coverage Δ
components/mention/mention-trigger.ts 98.30% <96.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bbdab...a156afc. Read the comment docs.

@simplejason
Copy link
Member

Since this PR is based angular v12, so I prefer to rebase it with master first :) If you don't mind, I will perform this action.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 73af728 into NG-ZORRO:master Feb 25, 2022
@arturovt arturovt deleted the perf/mention-trigger branch February 25, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants