Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:graph): do not run change detection on animation frame #7132

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 19, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #7132 (93a1e69) into master (55f1e04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7132   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         488      488           
  Lines       15937    15937           
  Branches     2579     2579           
=======================================
  Hits        14302    14302           
  Misses       1002     1002           
  Partials      633      633           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f1e04...93a1e69. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 1ceaf70 into NG-ZORRO:master Jan 13, 2022
@arturovt arturovt deleted the perf/graph-anim-frame branch January 13, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants