Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:table): spawn timers and add listener outside of the zone #7140

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

@zorro-bot
Copy link

zorro-bot bot commented Dec 23, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #7140 (34064cf) into master (ab78821) will increase coverage by 1.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7140      +/-   ##
==========================================
+ Coverage   89.75%   91.67%   +1.92%     
==========================================
  Files         488      486       -2     
  Lines       15937    15954      +17     
  Branches     2579     2589      +10     
==========================================
+ Hits        14304    14626     +322     
- Misses       1001     1014      +13     
+ Partials      632      314     -318     
Impacted Files Coverage Δ
...ts/table/src/table/table-inner-scroll.component.ts 80.00% <100.00%> (-1.43%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/core/overlay/nz-connected-overlay.ts 80.00% <0.00%> (-5.72%) ⬇️
components/input/input.directive.ts 93.93% <0.00%> (-3.04%) ⬇️
components/menu/menu-item.directive.ts 76.38% <0.00%> (-0.43%) ⬇️
components/cascader/cascader-li.component.ts 100.00% <0.00%> (ø)
components/transfer/transfer-list.component.ts 96.22% <0.00%> (ø)
components/test.ts
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78821...34064cf. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit ec248c9 into NG-ZORRO:master Feb 24, 2022
@arturovt arturovt deleted the perf/table-inner-scroll branch February 24, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants