Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:resizable): do not run change detection on mousedown and touchstart events #7170

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 30, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #7170 (f4dd3ac) into master (77db914) will increase coverage by 0.03%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7170      +/-   ##
==========================================
+ Coverage   91.67%   91.70%   +0.03%     
==========================================
  Files         486      486              
  Lines       15868    15866       -2     
  Branches     2587     2588       +1     
==========================================
+ Hits        14547    14550       +3     
+ Misses       1007     1001       -6     
- Partials      314      315       +1     
Impacted Files Coverage Δ
components/resizable/resizable.directive.ts 95.29% <90.00%> (-0.62%) ⬇️
components/resizable/resizable.service.ts 100.00% <100.00%> (ø)
components/resizable/resize-handle.component.ts 100.00% <100.00%> (ø)
components/resizable/resize-handles.component.ts 100.00% <100.00%> (ø)
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77db914...f4dd3ac. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 9a8d794 into NG-ZORRO:master Feb 22, 2022
@arturovt arturovt deleted the perf/resizable-mousedown branch February 22, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants