Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): fix close icon position without title property #7176

merged 3 commits into from Jan 13, 2022


Copy link

@chenc041 chenc041 commented Jan 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
fix close icon button without title property

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7164

What is the new behavior?

close icon button will align right, when does not set nzTitle property

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Jan 2, 2022

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #7176 (c29c7bc) into master (77db914) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7176   +/-   ##
  Coverage   91.67%   91.67%           
  Files         486      486           
  Lines       15868    15868           
  Branches     2587     2587           
  Hits        14547    14547           
  Misses       1007     1007           
  Partials      314      314           
Impacted Files Coverage Δ
components/drawer/drawer.component.ts 98.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77db914...c29c7bc. Read the comment docs.

components/drawer/drawer.component.ts Show resolved Hide resolved
components/drawer/style/drawer.less Outdated Show resolved Hide resolved
@simplejason simplejason merged commit a6195b9 into NG-ZORRO:master Jan 13, 2022
@chenc041 chenc041 deleted the fix-drawer-header branch January 14, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants